Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): don't commit registry completions on "/" #20902

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix(lsp): don't commit registry completions on "/" #20902

merged 1 commit into from
Oct 13, 2023

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #17235.

dsherret
dsherret approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nayeemrmn nayeemrmn merged commit bd238be into denoland:main Oct 13, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the lsp-commit-on-slash-remove branch October 15, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp - Import specifier auto-completes to first registry in drop down after typing https:/ then /
2 participants
@nayeemrmn @dsherret