Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable another flaky Node compat test #20846

Merged
merged 1 commit into from
Oct 9, 2023
Merged

chore: disable another flaky Node compat test #20846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions cli/tests/node_compat/test/internet/test-dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,24 +214,26 @@ TEST(async function test_resolveNs(done) {
checkWrap(req);
});

TEST(function test_resolveNs_failure(done) {
dnsPromises.resolveNs(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe open an issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #20838 is for this

// instead of `ENOTFOUND`.
// TEST(function test_resolveNs_failure(done) {
// dnsPromises.resolveNs(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));

const req = dns.resolveNs(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveNs(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');

assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);

done();
});
// done();
// });

checkWrap(req);
});
// checkWrap(req);
// });

TEST(async function test_resolveSrv(done) {
function validateResult(result) {
Expand Down