Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lsp): optimize formatting minified files #20829

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #20754. Uses one big text edit if the formatter produces a substantial change in line count. Also moves diff generation to the blocking thread.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 35f028d into denoland:main Oct 9, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the lsp-format-minified-perf branch October 9, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP: Formatting minified JS/JSON files is slow
2 participants