Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): send "deno/didChangeDenoConfiguration" notifications #20827

Merged
merged 6 commits into from
Oct 12, 2023
Merged

feat(lsp): send "deno/didChangeDenoConfiguration" notifications #20827

merged 6 commits into from
Oct 12, 2023

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Oct 8, 2023 •
edited
Loading

Half of denoland/vscode_deno#963. Coupled with denoland/vscode_deno#964. Also sends the deno.json file URI with each task def in deno/task responses.

@nayeemrmn nayeemrmn mentioned this pull request Oct 8, 2023
Merged
bartlomieju
bartlomieju reviewed Oct 10, 2023
View reviewed changes
cli/lsp/client.rs Show resolved Hide resolved
cli/lsp/language_server.rs Outdated Show resolved Hide resolved
test_util/src/lsp.rs Outdated Show resolved Hide resolved
@bartlomieju
Copy link
Member

does this panel list both "tasks" from "deno.json" file as well as "scripts" from "package.json"?

It doesn't apparently, we would patch that in main repo by including it in the deno/task response

@nayeemrmn could we handle that before landing the PR?

nayeemrmn
nayeemrmn commented Oct 11, 2023
View reviewed changes
cli/lsp/language_server.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great change!

@nayeemrmn nayeemrmn merged commit 5dd010a into denoland:main Oct 12, 2023
13 checks passed
@nayeemrmn nayeemrmn mentioned this pull request Oct 12, 2023
Closed
bartlomieju pushed a commit that referenced this pull request Oct 12, 2023
@nayeemrmn @bartlomieju
feat(lsp): send "deno/didChangeDenoConfiguration" notifications (#20827)
55c6bd7
@nayeemrmn nayeemrmn deleted the lsp-change-deno-config-notification branch October 12, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nayeemrmn @bartlomieju