Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lsp): add "deno.reloadImportRegistries" as a command #20823

Merged
merged 6 commits into from
Oct 10, 2023
Merged

refactor(lsp): add "deno.reloadImportRegistries" as a command #20823

merged 6 commits into from
Oct 10, 2023

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Oct 8, 2023 •
edited
Loading

Coupled with denoland/vscode_deno#962.

Moves custom request deno/reloadImportRegistries to command deno.reloadImportRegistries.

@nayeemrmn nayeemrmn marked this pull request as draft October 8, 2023 00:20
@nayeemrmn nayeemrmn mentioned this pull request Oct 8, 2023
Merged
@nayeemrmn nayeemrmn changed the title refactor(lsp): add deno.reloadImportRegistries as a command refactor(lsp): add "deno.reloadImportRegistries" as a command Oct 8, 2023
@nayeemrmn nayeemrmn marked this pull request as ready for review October 9, 2023 06:01
bartlomieju
bartlomieju approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that could be added for this one?

@nayeemrmn
Copy link
Collaborator Author

Is there a test that could be added for this one?

I added a simple test to check that the command exists and succeeds, more seems difficult...

@nayeemrmn nayeemrmn merged commit 6bbccb7 into denoland:main Oct 10, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the lsp-reload-import-registries-as-command branch October 10, 2023 04:54
bartlomieju pushed a commit that referenced this pull request Oct 12, 2023
@nayeemrmn @bartlomieju
refactor(lsp): add "deno.reloadImportRegistries" as a command (#20823)
70e49d5
This was referenced Mar 28, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nayeemrmn @bartlomieju