Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): percent-encode host in deno: specifiers #20811

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix(lsp): percent-encode host in deno: specifiers #20811

merged 1 commit into from
Oct 6, 2023

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #18460.

bartlomieju
bartlomieju approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 677a591 into denoland:main Oct 6, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the lsp-normalize-specifier-with-port branch October 6, 2023 13:47
bartlomieju pushed a commit that referenced this pull request Oct 12, 2023
@nayeemrmn @bartlomieju
fix(lsp): percent-encode host in deno: specifiers (#20811)
2b3396d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

language server errors on go-to-definition for localhost url
2 participants
@nayeemrmn @bartlomieju