Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: FeatureChecker integration in ext/ crates #20797

Merged
merged 13 commits into from
Oct 12, 2023
Merged

refactor: FeatureChecker integration in ext/ crates #20797

merged 13 commits into from
Oct 12, 2023

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Oct 5, 2023 •
edited
Loading

Towards #20779.

bartlomieju
bartlomieju commented Oct 8, 2023
View reviewed changes
Copy link
Member Author

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by denoland/deno_core#259

@bartlomieju bartlomieju mentioned this pull request Oct 8, 2023
Merged
bartlomieju added a commit that referenced this pull request Oct 9, 2023
@bartlomieju
refactor: remove TimersPermissions::check_unstable (#20831)
2167a52 
This is dead code that was not used in any way.

Ref #20797
@bartlomieju bartlomieju marked this pull request as ready for review October 10, 2023 23:38
@kt3k
Copy link
Member

kt3k commented Oct 12, 2023

Looks like the error like the below seems happening. Do you see what causes this?

error: Uncaught TypeError: toUtf8 is not a function
const blob = new Blob(
             ^
    at Object.encode (ext:core/01_core.js:862:38)
    at processBlobParts (ext:deno_web/09_file.js:162:26)
    at new Blob (ext:deno_web/09_file.js:235:29)
    at file:https:///Users/kt3k/denoland/deno/a.js:1:14

@kt3k
Copy link
Member

kt3k commented Oct 12, 2023

The code diffs look good to me.

littledivy
littledivy approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) October 12, 2023 15:40
@bartlomieju bartlomieju merged commit c464cd7 into denoland:main Oct 12, 2023
13 checks passed
@bartlomieju bartlomieju deleted the feature_checker branch October 12, 2023 16:35
bartlomieju added a commit that referenced this pull request Oct 12, 2023
@bartlomieju
refactor: remove TimersPermissions::check_unstable (#20831)
6157942 
This is dead code that was not used in any way.

Ref #20797
bartlomieju added a commit that referenced this pull request Oct 12, 2023
@bartlomieju
refactor: FeatureChecker integration in ext/ crates (#20797)
b6369e6 
Towards #20779.
@kt3k kt3k mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlomieju @kt3k @littledivy