fix(ext/http): Deno.Server should not be thenable #20723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
async_fn_thenable
branch
from
8a0c42c
to
6bf5c6f
Compare
Otherwise you can not return `Deno.Server` from async functions.
lucacasonato
force-pushed
the
async_fn_thenable
branch
from
6bf5c6f
to
8564d36
Compare
kt3k
reviewed
Sep 28, 2023
|
Good catch. LGTM! |
Co-authored-by: Yoshiya Hinosawa <[email protected]>
kt3k
reviewed
Sep 30, 2023
bartlomieju
added a commit
that referenced
this pull request
Oct 12, 2023
Otherwise you can not return `Deno.Server` from async functions. Co-authored-by: Yoshiya Hinosawa <[email protected]> Co-authored-by: Bartek Iwańczuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise you can not return
Deno.Serverfrom async functions.Fixes #20446