fix(jupyter): await Jupyter.display evaluation #20646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgbkrk
reviewed
Sep 23, 2023
| @@ -599,8 +609,12 @@ async fn get_jupyter_display_or_eval_value( | |||
| return Ok(HashMap::default()); | |||
| } | |||
|
|
|||
| if let Some(data) = get_jupyter_display(session, evaluate_result).await? { | |||
| return Ok(data); | |||
| // If the response is a primitive value we don't need to try and format | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #20528.
There are a few things happening here:
object[Symbol.for("Jupyter.display")]is wrapped in atry/catchblockobject[Symbol.for("Jupyter.display")]is awaitedI was unable to reproduce the "Promise was collected" error with this change.