feat(ext/websocket): split websocket read/write halves #20579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
mmastrac
force-pushed
the
split_websocket
branch
2 times, most recently
from
4b76bab
to
692e050
Compare
mmastrac
changed the title
mmastrac
force-pushed
the
split_websocket
branch
from
692e050
to
376c186
Compare
mmastrac
force-pushed
the
split_websocket
branch
from
5926c9f
to
b472e5b
Compare
bartlomieju
approved these changes
Oct 30, 2023
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Oct 30, 2023
Fixes some UB when sending and receiving at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on this in concert with denoland/fastwebsockets#48