Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/websocket): use rustls-tokio-stream instead of tokio-rustls #20518

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Sep 15, 2023

Use new https://github.com/denoland/rustls-tokio-stream project instead of tokio-rustls for direct websocket connections. This library was written from the ground up to be more reliable and should help with various bugs that may occur due to underlying bugs in the old library.

Believed to fix #20355, #18977, #20948

@jflatow
Copy link
Contributor

jflatow commented Oct 5, 2023

Actually, I think there's still a race condition. The only substantial change I see between this and the previous version is the printlns, and that one works for me while this one doesn't. I just recompiled the old one (eb29ac1dd) to make sure and confirmed, it runs relatively slow but works.

@mmastrac
Copy link
Contributor Author

mmastrac commented Oct 6, 2023

I am starting to suspect it's a handshake issue here... I might integrate fastwebsockets directly as a test in the TLS library to see if I can track this down.

@jespertheend
Copy link
Contributor

I can confirm this PR fixes at least #20948

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

Can you add to description any issues this PR closes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants