Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use flatbuffer create functions to add fields #2046

Merged
merged 2 commits into from
Apr 8, 2019
Merged

use flatbuffer create functions to add fields #2046

merged 2 commits into from
Apr 8, 2019

Conversation

orsi
Copy link
Contributor

@orsi orsi commented Apr 4, 2019 •
edited
Loading

Cleaning and reducing code in the TS core library that handles building flatbuffers by using the create functions provided by flatbuffers.

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kevinkassimo
Copy link
Contributor

Hi, thanks for the PR!
Please run ./tools/format.py and ./tools/link.py. Also run ./tools/test.py to ensure test passing locally.

@orsi
Copy link
Contributor Author

orsi commented Apr 4, 2019

Will do once I figure out how to run format.py. Cf. #2045

ry
ry approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - thanks - LGTM

@ry ry merged commit 3452a10 into denoland:master Apr 8, 2019
@orsi orsi deleted the flat_buffers-ts-clean branch April 9, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@orsi @CLAassistant @kevinkassimo @ry