Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node_compat): add test-http-url.parse* #20458

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

wafuwafu13
Copy link
Contributor

add test-http-url.parse*
none logical change

server.close();
});

// TODO(wafuwafu13): rejectUnauthorized is always true in Deno
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref:

this.ssl = new class {
verifyError() {
return null; // Never fails, rejectUnauthorized is always true in Deno.
}
}();

@wafuwafu13 wafuwafu13 marked this pull request as draft September 11, 2023 21:48
@wafuwafu13 wafuwafu13 marked this pull request as ready for review September 12, 2023 20:00
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartlomieju bartlomieju merged commit 9017e78 into denoland:main Sep 30, 2023
13 checks passed
bartlomieju pushed a commit that referenced this pull request Oct 12, 2023
Add `test-http-url.parse*` tests for Node compat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants