Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude internal JS files from coverage #20448

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix: exclude internal JS files from coverage #20448

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9682a03
fix: exclude internal JS files from coverage
marvinhagemeister Sep 11, 2023
cb00a21
chore: add test for exluding node* in coverage
marvinhagemeister Sep 11, 2023
8b1091c
chore: fix formatting error
marvinhagemeister Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: fix formatting error
  • Loading branch information
@marvinhagemeister
marvinhagemeister committed Sep 11, 2023
commit 8b1091c733579b26596409f6706a7259e4b87e95
4 changes: 3 additions & 1 deletion cli/tools/coverage/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ impl CoverageCollector {
let script_coverages = self.take_precise_coverage().await?.result;
for script_coverage in script_coverages {
// Filter out internal JS files from being included in coverage reports
if script_coverage.url.starts_with("ext:") || script_coverage.url.starts_with("[ext:") {
if script_coverage.url.starts_with("ext:")
|| script_coverage.url.starts_with("[ext:")
{
continue;
}

Expand Down