fix(cli): for main-module that exists in package.json, use the version defined in package.json directly #20328

await-ovo · 2023-08-29T15:58:22Z

fix #20302

…n defined in package.json directly

dsherret

Almost there! Just needs to handle sub paths.

cli/worker.rs

cli/tests/integration/npm_tests.rs

…ecessarily correspond to the name

dsherret

LGTM. Thanks!

fix(cli): for main-module that exists in package.json, use the versio…

54b07d2

…n defined in package.json directly

bartlomieju requested a review from dsherret August 29, 2023 16:01

await-ovo and others added 2 commits August 30, 2023 00:44

chore(cli): add test

29e593b

Merge branch 'main' into fix-npm-main-module-package-json

6675f6b

dsherret requested changes Sep 5, 2023

View reviewed changes

cli/worker.rs Outdated Show resolved Hide resolved

cli/worker.rs Outdated Show resolved Hide resolved

cli/tests/integration/npm_tests.rs Show resolved Hide resolved

await-ovo and others added 3 commits September 7, 2023 19:01

chore: add test case

dae0e57

Merge branch 'main' into fix-npm-main-module-package-json

676a0f4

Look at the dependency values instead of the key as the key doesn't n…

381c9e5

…ecessarily correspond to the name

dsherret approved these changes Sep 18, 2023

View reviewed changes

dsherret enabled auto-merge (squash) September 18, 2023 19:14

dsherret merged commit dc1da30 into denoland:main Sep 18, 2023
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): for main-module that exists in package.json, use the version defined in package.json directly #20328

fix(cli): for main-module that exists in package.json, use the version defined in package.json directly #20328

await-ovo commented Aug 29, 2023

dsherret left a comment

dsherret left a comment

fix(cli): for main-module that exists in package.json, use the version defined in package.json directly #20328

fix(cli): for main-module that exists in package.json, use the version defined in package.json directly #20328

Conversation

await-ovo commented Aug 29, 2023

dsherret left a comment

Choose a reason for hiding this comment

dsherret left a comment

Choose a reason for hiding this comment