Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text_encoding web compatibility #2032

Merged
merged 1 commit into from
Apr 1, 2019
Merged

text_encoding web compatibility #2032

merged 1 commit into from
Apr 1, 2019

Conversation

justjavac
Copy link
Contributor

make new TextDecoder().toString() web compatibility

Chrome:

"[object TextDecoder]"

Firefox:

"[object TextDecoder]"

Safari:

"[object TextDecoder]"

ry
ry approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@ry ry merged commit 659acad into denoland:master Apr 1, 2019
@justjavac justjavac deleted the text-encoding-tostring branch April 2, 2019 00:46
justjavac added a commit to justjavac/deno that referenced this pull request Apr 2, 2019
@justjavac
Improve new TextDecoder().toString() (denoland#2032)
6b408ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justjavac @ry