Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TypeScript 2.4 #2027

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Upgrade to TypeScript 2.4 #2027

merged 1 commit into from
Apr 1, 2019

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Apr 1, 2019

This PR upgrades Deno to TypeScript 2.4.

ts-morph does not yet support TypeScript 2.4 (@dsherret), so there were some changes ts_library_builder to allow it to use the library files from the version of TypeScript that it comes bundled with, which is used to validate the output library file. Deno will still use 2.4 and the associated library files. I also fixed several linting issues with ts_library_builder as well.

@dsherret
Copy link
Member

dsherret commented Apr 1, 2019

Hey @kitsonk, I can get a patch version (1.3.3) out that adds ts 3.4 support (will do so tomorrow).

There were some breaking changes in ts 3.4 and so I added ts 3.4 support to my upcoming 2.0 (wanted to make a couple small api changes to accommodate it on my end too), but now I'm delayed on releasing it for a couple weeks... so I'll do a custom fix for ts 3.4 in ts-morph 1.3.3.

@dsherret
Copy link
Member

dsherret commented Apr 1, 2019

@kitsonk also, thanks for keeping me in the loop about this! It helps to guide my priorities :)

@ztplz
Copy link
Contributor

ztplz commented Apr 1, 2019

Hmm, 2.4 => 3.4.

@kitsonk
Copy link
Contributor Author

kitsonk commented Apr 1, 2019

DOH! Yes... Thanks @ztplz

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM

@ry ry merged commit ada5ffa into denoland:master Apr 1, 2019
@dsherret
Copy link
Member

dsherret commented Apr 1, 2019

@kitsonk FYI, released ts-morph 1.3.3 which has ts 3.4 support.

Also, just looked at the change you made and that looked good to do anyway.

justjavac pushed a commit to justjavac/deno that referenced this pull request Apr 2, 2019
@JamesHenry
Copy link

@kitsonk Just checking, was there any reason you didn't update the @typescript-eslint deps as part of this?

There were some significant performance improvements added in 1.5.0 and then TypeScript 3.4 support was made official in 1.6.0

@kitsonk
Copy link
Contributor Author

kitsonk commented Apr 8, 2019

@JamesHenry we have just been pinning all our dependencies and only upgrading when we believe there is something of value. I will raise a PR to update those.

@kitsonk kitsonk deleted the ts-24 branch June 4, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants