refactor: use resourceForReadableStream for fetch #20217
Merged
+312
−359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
commented
Aug 21, 2023
ext/fetch/lib.rs
Outdated
| @@ -214,6 +212,58 @@ pub fn get_or_create_client_from_state( | |||
| } | |||
| } | |||
|
|
|||
| struct ResourceToBodyAdapter(Rc<dyn Resource>, Option<Pin<Box<dyn Future<Output = Result<BufView, Error>>>>>); | |||
There was a problem hiding this comment.
This pattern is identical to one in ext/http, so it might be worth turning this into a deno_core utility.
mmastrac
force-pushed
the
fetch_new_stream
branch
2 times, most recently
from
57431bc
to
5813961
Compare
bartlomieju
changed the title
mmastrac
force-pushed
the
fetch_new_stream
branch
2 times, most recently
from
963c44c
to
ed19140
Compare
mmastrac
force-pushed
the
fetch_new_stream
branch
from
d4d9a99
to
4dabae8
Compare
crowlKats
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch
ext/fetchover toresourceForReadableStreamto simplify and unify implementation withext/serve. This allows us to work in Rust with resources only.Two additional changes made to
resourceForReadableStreamwere required:resourceForReadableStreamwhich translates tosize_hint