Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid search prototype chain #2019

Merged
merged 2 commits into from
Mar 30, 2019

Conversation

justjavac
Copy link
Contributor

The in operator returns true if the specified property in its prototype chain.

> target.addEventListener("toString",  listener)

Uncaught TypeError: this.listeners[type].push is not a function
    at addEventListener (deno/js/event_target.ts:21:28)
    at <unknown>:1:8
    at evaluate (deno/js/repl.ts:93:34)
    at replLoop (deno/js/repl.ts:151:13)

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 51c6f33 into denoland:master Mar 30, 2019
@justjavac justjavac deleted the avoid-search-prototype-chain branch April 1, 2019 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants