New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid search prototype chain #2019

Merged

ry merged 2 commits into denoland:master from justjavac:avoid-search-prototype-chain

Mar 30, 2019

Contributor

justjavac commented Mar 30, 2019

The in operator returns true if the specified property in its prototype chain.

> target.addEventListener("toString",  listener)

Uncaught TypeError: this.listeners[type].push is not a function
    at addEventListener (deno/js/event_target.ts:21:28)
    at <unknown>:1:8
    at evaluate (deno/js/repl.ts:93:34)
    at replLoop (deno/js/repl.ts:151:13)

justjavac added 2 commits

March 30, 2019 14:31


avoid search prototype chain

0ad80a8


fix format

29f5ea9

ry approved these changes

View reviewed changes

Member

ry left a comment

LGTM

ry merged commit 51c6f33 into denoland:master

justjavac deleted the avoid-search-prototype-chain branch

April 1, 2019 04:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment