fix(ext/kv): retry transaction on SQLITE_BUSY errors
#20189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
approved these changes
Aug 17, 2023
ext/kv/sqlite.rs
Outdated
| Err(e) => { | ||
| if let Some(x) = e.downcast_ref::<rusqlite::Error>() { | ||
| if x.sqlite_error_code() == Some(rusqlite::ErrorCode::DatabaseBusy) { | ||
| log::warn!("kv: Database is busy, retrying"); |
There was a problem hiding this comment.
Suggested change
| log::warn!("kv: Database is busy, retrying"); |
Or use log::debug
littledivy
pushed a commit
to littledivy/deno
that referenced
this pull request
Aug 21, 2023
Properly handle the `SQLITE_BUSY` error code by retrying the transaction. Also wraps database initialization logic in a transaction to protect against incomplete/concurrent initializations. Fixes denoland#20116.
littledivy
pushed a commit
that referenced
this pull request
Aug 21, 2023
Properly handle the `SQLITE_BUSY` error code by retrying the transaction. Also wraps database initialization logic in a transaction to protect against incomplete/concurrent initializations. Fixes #20116.
losfair
added a commit
to losfair/deno
that referenced
this pull request
Aug 24, 2023
Properly handle the `SQLITE_BUSY` error code by retrying the transaction. Also wraps database initialization logic in a transaction to protect against incomplete/concurrent initializations. Fixes denoland#20116.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle the
SQLITE_BUSYerror code by retrying the transaction.Also wraps database initialization logic in a transaction to protect against incomplete/concurrent initializations.
Fixes #20116.