Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check EventTarget params #2018

Merged
merged 2 commits into from
Mar 30, 2019
Merged

check EventTarget params #2018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
165b79d
check `EventTarget` params
justjavac Mar 29, 2019
38a0072
Merge branch 'master' into check-event-target-params
justjavac Mar 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions js/event_target.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
import * as domTypes from "./dom_types";
import { requiredArguments } from "./util";

/* TODO: This is an incomplete implementation to provide functionality
* for Event. A proper spec is still required for a proper Web API.
Expand All @@ -14,6 +15,7 @@ export class EventTarget implements domTypes.EventTarget {
listener: domTypes.EventListenerOrEventListenerObject | null,
_options?: boolean | domTypes.AddEventListenerOptions
): void {
requiredArguments("EventTarget.addEventListener", arguments.length, 2);
if (!this.listeners.hasOwnProperty(type)) {
this.listeners[type] = [];
}
Expand All @@ -27,6 +29,7 @@ export class EventTarget implements domTypes.EventTarget {
callback: domTypes.EventListenerOrEventListenerObject | null,
_options?: domTypes.EventListenerOptions | boolean
): void {
requiredArguments("EventTarget.removeEventListener", arguments.length, 2);
if (this.listeners.hasOwnProperty(type) && callback !== null) {
this.listeners[type] = this.listeners[type].filter(
listener => listener !== callback
Expand All @@ -35,6 +38,7 @@ export class EventTarget implements domTypes.EventTarget {
}

public dispatchEvent(event: domTypes.Event): boolean {
requiredArguments("EventTarget.dispatchEvent", arguments.length, 1);
if (!this.listeners.hasOwnProperty(event.type)) {
return true;
}
Expand Down