Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite websocket to use op2 macro #20140

Merged
merged 13 commits into from
Oct 4, 2023

Conversation

littledivy
Copy link
Member

No description provided.

@bartlomieju
Copy link
Member

bartlomieju commented Aug 17, 2023

Blocked on support for permission trait and op2(async, fast) (denoland/deno_core#147)

@bartlomieju bartlomieju marked this pull request as ready for review September 23, 2023 12:57
@bartlomieju bartlomieju added the ci-bench put this on a PR to run the benchmarks label Sep 23, 2023
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@bartlomieju bartlomieju enabled auto-merge (squash) October 4, 2023 20:55
@bartlomieju bartlomieju merged commit 1a81b28 into denoland:main Oct 4, 2023
13 checks passed
@bartlomieju bartlomieju deleted the op2_websocket branch October 4, 2023 22:03
bartlomieju added a commit that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-bench put this on a PR to run the benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants