Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deno_core -> 0.202.0 #20135

Merged
merged 8 commits into from
Aug 12, 2023
Merged

chore: deno_core -> 0.202.0 #20135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a158a34
chore: deno_core -> 0.201.0
mmastrac Aug 11, 2023
b55aba3
Patches from deno_core changes
mmastrac Aug 11, 2023
6ff2408
[ci]
mmastrac Aug 11, 2023
fcb2058
lock
mmastrac Aug 11, 2023
9eb0dc1
Remove fixed v8 version too (inherit from deno_core)
mmastrac Aug 11, 2023
3606a1e
Fix test
mmastrac Aug 11, 2023
f21ae62
Re-bump deno_core and update expectations
mmastrac Aug 12, 2023
7cd24d4
lock
mmastrac Aug 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,9 @@ license = "MIT"
repository = "https://github.com/denoland/deno"

[workspace.dependencies]
v8 = { version = "0.74.1", default-features = false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any rationale why this got removed (it actually broke the homebrew build)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easier for us to manage version bumps if they flow from the upstream deno_core dep. rusty_v8, deno_core, serde_v8 and deno_ops all need to bump in lockstep.

deno_ast = { version = "0.27.0", features = ["transpiling"] }

deno_core = "0.200.0"
deno_core = "0.202.0"

deno_runtime = { version = "0.123.0", path = "./runtime" }
napi_sym = { version = "0.45.0", path = "./cli/napi/sym" }
Expand Down
2 changes: 1 addition & 1 deletion cli/tests/testdata/node/test.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ error: Error: rejected from reject fail
at [WILDCARD]

./node/test.js (uncaught error)
error: Error: rejected from unhandled rejection fail
error: (in promise) Error: rejected from unhandled rejection fail
Promise.reject(new Error("rejected from unhandled rejection fail"));
^
at [WILDCARD]
Expand Down
4 changes: 2 additions & 2 deletions cli/tests/testdata/run/heapstats.js.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Allocated: 8MB
Freed: -8MB
Allocated: 4MB
Freed: -4MB
12 changes: 4 additions & 8 deletions ext/io/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,14 +170,10 @@ impl FsStat {
pub trait File {
fn read_sync(self: Rc<Self>, buf: &mut [u8]) -> FsResult<usize>;
async fn read(self: Rc<Self>, limit: usize) -> FsResult<BufView> {
let vec = vec![0; limit];
let buf = BufMutView::from(vec);
let (nread, buf) = self.read_byob(buf).await?;
let mut vec = buf.unwrap_vec();
if vec.len() != nread {
vec.truncate(nread);
}
Ok(BufView::from(vec))
let buf = BufMutView::new(limit);
let (nread, mut buf) = self.read_byob(buf).await?;
buf.truncate(nread);
Ok(buf.into_view())
}
async fn read_byob(
self: Rc<Self>,
Expand Down
8 changes: 6 additions & 2 deletions tools/wpt/expectation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2807,8 +2807,12 @@
},
"class-string-interface.any.html": true,
"class-string-interface.any.worker.html": true,
"class-string-iterator-prototype-object.any.html": true,
"class-string-iterator-prototype-object.any.worker.html": true,
"class-string-iterator-prototype-object.any.html": [
"Object.prototype.toString applied after deleting @@toStringTag"
],
"class-string-iterator-prototype-object.any.worker.html": [
"Object.prototype.toString applied after deleting @@toStringTag"
],
"class-string-named-properties-object.window.html": false,
"global-immutable-prototype.any.html": [
"Setting to a different prototype"
Expand Down