Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): navigator.userAgent in web worker #20129

Merged
merged 6 commits into from
Aug 15, 2023

Conversation

await-ovo
Copy link
Contributor

fix #20079

@bartlomieju
Copy link
Member

Nice fix! Could you please update tools/wpt/expectation.json to mark relevant WPT tests as passing now?

@await-ovo
Copy link
Contributor Author

Nice fix! Could you please update tools/wpt/expectation.json to mark relevant WPT tests as passing now?

Ok ~, will try to update it ~

@await-ovo
Copy link
Contributor Author

Sorry, I've tried a few times and still don't know how to update this file, can you help me to update this file to make sure the test passes? thanks

@bartlomieju
Copy link
Member

@await-ovo sure, I'll handle that. Thanks for the PR!

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @await-ovo!

@bartlomieju bartlomieju merged commit 41cad21 into denoland:main Aug 15, 2023
13 checks passed
littledivy pushed a commit to littledivy/deno that referenced this pull request Aug 21, 2023
littledivy pushed a commit that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is this navigator.userAgent expected?
2 participants