Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/abort): trigger AbortSignal events in correct order #20095

Merged
merged 2 commits into from
Aug 8, 2023
Merged

fix(ext/abort): trigger AbortSignal events in correct order #20095

merged 2 commits into from
Aug 8, 2023

Conversation

marcosc90
Copy link
Contributor

This PR ensures that the original signal event is fired before any dependent signal events.

The enabled tests fail on main:

assert_array_equals: Abort events fired in correct order expected property 0 to be 
"original-aborted" but got "clone-aborted" (expected array ["original-aborted", "clone-aborted"] 
got ["clone-aborted", "original-aborted"])

bartlomieju
bartlomieju approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartlomieju bartlomieju merged commit 557b11b into denoland:main Aug 8, 2023
13 checks passed
@marcosc90 marcosc90 deleted the fix-abort-events branch August 8, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcosc90 @bartlomieju