Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fmt): do not insert expr stmt leading semi-colon in do while stmt body #20093

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix(fmt): do not insert expr stmt leading semi-colon in do while stmt body #20093

merged 1 commit into from
Aug 8, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 8, 2023 •
edited
Loading

This is for when semiColons: false

Closes #20089

lino-levan
lino-levan approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@lino-levan lino-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bartlomieju
bartlomieju approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit a037ed7 into main Aug 8, 2023
13 checks passed
@dsherret dsherret deleted the fix_fmt_no_semi_do_while_stmt branch August 8, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lino-levan lino-levan lino-levan approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno fmt can insert a code-breaking semicolon
3 participants
@dsherret @lino-levan @bartlomieju