fix(ext/timers): some timers are not resolved #20055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milaz
reviewed
Aug 4, 2023
| @@ -286,7 +287,7 @@ function runAfterTimeout(task, millis, timerInfo) { | |||
| while (currentEntry !== null) { | |||
There was a problem hiding this comment.
Would using a priority queue be a better idea than looping over a doubly linked list, especially in the cases where the user creates a large number of simultaneously running timers?
There was a problem hiding this comment.
@milaz we want to completely overhaul timers implementation so they work nicely with eg. "AsyncLocalStorage". I would prefer to punt on changing the underlying machinery until that happens, but I will definitely take your suggestion into account 👍
|
For a test, maybe we can set up a number of timers for ~1ms and call a non-async blocking op for 100ms, forcing them all to resolve at once? |
bartlomieju
changed the title
littledivy
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19866