Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/http): unify default gzip compression level #20050

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Aug 4, 2023

This tweaks the HTTP response-writer in order to align the two possible execution flows into using the same gzip default compression level, that is 1 (otherwise the implicit default level is 6).

This tweaks the HTTP response-writer in order to align the two
possible execution flows into using the same gzip default compression
level, that is `1` (otherwise the implicit default level is `6`).
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucab lucab merged commit 5abf4cd into denoland:main Aug 4, 2023
13 checks passed
@lucab lucab deleted the ups/http-gzip-compression-quality-1 branch August 4, 2023 15:28
@mmastrac
Copy link
Contributor

mmastrac commented Aug 4, 2023

As a note for future reference -- this affects serveHttp, but not serve. We also need to fix the brotli path there as well as it appears to be using the default compression level.

ry pushed a commit to ry/deno that referenced this pull request Aug 15, 2023
This tweaks the HTTP response-writer in order to align the two possible
execution flows into using the same gzip default compression level, that
is `1` (otherwise the implicit default level is `6`).
lucab added a commit to lucab/deno that referenced this pull request Aug 16, 2023
This tweaks the HTTP response-writer in order to align the two possible
execution flows into using the same gzip default compression level, that
is `1` (otherwise the implicit default level is `6`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants