fix(ext/file): resolve unresolved Promise in Blob.stream #20039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some crashing WPT tests due to an unresolved promise.
This could be a stream spec bug
When
controller.close
is called on a byob stream, there's no cleanup of pendingreadIntoRequests
. The only cleanup of pendingreadIntoRequests
happen when.byobRequest.respond(0)
is called, it happens here:deno/ext/web/06_streams.js
Line 2026 in 6ba245f
readIntoRequest.closeSteps(chunk);
indeno/ext/web/06_streams.js
Line 2070 in 6ba245f
To reproduce:
Running the script triggers: