refactor(ext/fetch): refactor fetch to use new write_error method #20029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Sweet to have it removed altogether 👍
| @@ -293,7 +292,7 @@ where | |||
| match data { | |||
| None => { | |||
| // If no body is passed, we return a writer for streaming the body. | |||
| let (stream, tx) = MpscByteStream::new(); | |||
| let (tx, stream) = tokio::sync::mpsc::channel(1); | |||
There was a problem hiding this comment.
Are you sure having a buffer size of 1 won't cause any dead locks?
There was a problem hiding this comment.
It's currently set to 1 in MpscByteStream, and I used the same number for ext/http as well. I think that I'd like to include a buffer here, but it would more likely be at the byte level rather than at the packet level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for fast streams work -- this particular resource used a custom
mpsc-style stream, and this work will allow us to unify it with the streams inext/httpin time.Instead of using Option as an internal semaphore for "correctly completed EOF", we allow code to propagate errors into the channel which can be picked up by downstream sinks like Hyper. EOF is signalled using a more standard sender drop.