refactor(cli): move snapshot_from_lockfile function to deno_npm
#20024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the test cases fail because the error messages are changed. I'll fix them |
dsherret
reviewed
Aug 7, 2023
| @@ -819,16 +820,26 @@ impl CliOptions { | |||
|
|
|||
| if let Some(lockfile) = self.maybe_lockfile() { | |||
| if !lockfile.lock().overwrite { | |||
| return Ok(Some( | |||
| snapshot_from_lockfile(lockfile.clone(), api) | |||
There was a problem hiding this comment.
I think the code block below and the one in the language server are essentially the same thing? Could we maintain this snapshot_from_lockfile function in the CLI and then just have that call the deno_npm functions?
There was a problem hiding this comment.
Sounds good, how about this 9aa1e2d
bartlomieju
changed the title
snapshot_from_locklfile function to deno_npmsnapshot_from_lockfile function to deno_npm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves
snapshot_from_lockfilefunction to deno_npm crate. This allows this function to be called outside Deno CLI (in particular, Deno Deploy).Depends on:
snapshot_from_lockfilefrom denoland/deno deno_npm#27Lockfileinstance without accessing filesystem deno_lockfile#3 (transitively)