Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve entrypoint using import map #20018

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 2, 2023

This commit changes resolution of "entrypoint" to use import map
if one is provided for the following subcommands:

  • "deno run"
  • "deno doc"
  • "deno check"
  • "deno cache"

Closes #14066
Closes #19955

@bartlomieju bartlomieju marked this pull request as ready for review August 2, 2023 20:10
@bartlomieju bartlomieju marked this pull request as draft August 2, 2023 22:43
@bartlomieju
Copy link
Member Author

After some back and forth I decided not to land it for v1.36.0. There are some edge cases that need to be carefully considered and the test coverage should be plenty. I will land it for v1.37.0.

@mash-graz
Copy link
Contributor

Unfortunately this patch didn't get merged in one of the official releases until now and the issues mentioned in #19955, #14066 and #14760 are still unsolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support deno run resolving bare specifiers with import map Import maps don't always work with deno run
2 participants