Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regression in workers using dynamic imports #20006

Merged
merged 6 commits into from
Aug 2, 2023
Merged

fix: regression in workers using dynamic imports #20006

merged 6 commits into from
Aug 2, 2023

Conversation

bartlomieju
Copy link
Member

Closes #19903

@bartlomieju bartlomieju marked this pull request as ready for review August 1, 2023 21:42
@bartlomieju bartlomieju mentioned this pull request Aug 1, 2023
Closed
@bartlomieju bartlomieju enabled auto-merge (squash) August 2, 2023 00:04
dsherret
dsherret approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmastrac
mmastrac approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 9d1c329 into denoland:main Aug 2, 2023
13 checks passed
@bartlomieju bartlomieju deleted the worker_hang_regression branch August 2, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in import starting in Deno 1.32.4
3 participants
@bartlomieju @mmastrac @dsherret