Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused code #1985

Merged
merged 1 commit into from
Mar 22, 2019
Merged

remove unused code #1985

merged 1 commit into from
Mar 22, 2019

Conversation

justjavac
Copy link
Contributor

I added this code in my previous commit 0407646. This line of code is not needed, but I forgot to delete it.

ry
ry approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks. I wonder why lint doesn’t pick this up..

@ry ry merged commit efe9c18 into denoland:master Mar 22, 2019
@kitsonk
Copy link
Contributor

kitsonk commented Mar 23, 2019

Because it isn't unused. const console shadowed the global console.

@ry
Copy link
Member

ry commented Mar 23, 2019 •
edited

@kitsonk are you saying the removal was erroneous? Or just explaining why lint didn’t pick it up?

@kitsonk
Copy link
Contributor

kitsonk commented Mar 23, 2019

Why linting didn't pick it up. The removal was correct.

@justjavac justjavac deleted the fix-console-test branch March 23, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justjavac @kitsonk @ry