fix: make "suggest.autoImports" to switch completions from external modules #19845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the bug?
The
suggest.auto_importsshould suppress autocomplete suggestions for symbols that is not imported.But now it is passed to
include_completions_for_import_statements, that tells tsc to do autocomplete for theimportstatement or not.It causes the bug described in #15488.
What's fix in this PR?
I make the
suggest.auto_importsbe passed to the right optioninclude_completions_for_module_exportsthat tells tsc to not take suggestions for symbols from modules that is not imported.Fix #15488
Screenshots (after this PR)
I'm using denols with nvim-lspconfig.
If the
suggest.autoImportsis true (default),deno ls returns suggestions from modules that is not imported.
If the
suggest.autoImportsis false,deno ls returns only suggestions from modules that has already imported.