Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/net): Server connection callback include socket value #19779

Merged
merged 8 commits into from
Jul 18, 2023
Merged

fix(node/net): Server connection callback include socket value #19779

merged 8 commits into from
Jul 18, 2023

Conversation

crowlKats
Copy link
Member

Closes #19755

bartlomieju
bartlomieju reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that checks that socket is indeed included in the callback

bartlomieju
bartlomieju approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit bab0294 into denoland:main Jul 18, 2023
@crowlKats crowlKats deleted the net_server_connection_return_socket branch July 18, 2023 22:35
bartlomieju pushed a commit that referenced this pull request Jul 19, 2023
@crowlKats @bartlomieju
fix(node/net): Server connection callback include socket value (#19779)
7892655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node:net->Server doesn't contain socket
2 participants
@crowlKats @bartlomieju