Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): escape export identifier in double quoted string #19694

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix(npm): escape export identifier in double quoted string #19694

merged 1 commit into from
Jul 3, 2023

Conversation

await-ovo
Copy link
Contributor

fix #19679

@bartlomieju bartlomieju requested a review from dsherret July 3, 2023 18:08
dsherret
dsherret approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret enabled auto-merge (squash) July 3, 2023 18:13
@dsherret dsherret merged commit 208e65d into denoland:main Jul 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm package with exports[' " '] fails when imported
2 participants
@await-ovo @dsherret