Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/http): server use FakeSocket and add end method #19660

Merged
merged 7 commits into from
Jul 10, 2023
Merged

fix(node/http): server use FakeSocket and add end method #19660

merged 7 commits into from
Jul 10, 2023

Conversation

crowlKats
Copy link
Member

Fixes #19324

aapoalas
aapoalas previously requested changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably intentional but the res.socket!.end() in http_test.ts is successfully failing tests. ... I have no idea how it manages to do that though? I guess res.socket is actually undefined?

@crowlKats crowlKats merged commit 5cda141 into denoland:main Jul 10, 2023
11 checks passed
@crowlKats crowlKats deleted the server_fakesocket_end branch July 10, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@aapoalas aapoalas aapoalas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

socket.end is not a function
3 participants
@crowlKats @bartlomieju @aapoalas