fix(ext/websocket): Ensure that errors are available after async response returns #19642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we can revert 3fe44a5 with this change? |
I think so. I'll do that as part of this PR. |
f002398
to
75393d4
Compare
bartlomieju
reviewed
Jun 28, 2023
mmastrac
commented
Jun 29, 2023
| @@ -154,7 +154,6 @@ export async function runSingleTest( | |||
| harnessStatus = JSON.parse(line.slice(5)); | |||
| } else { | |||
| stderr += line + "\n"; | |||
| console.error(line); | |||
There was a problem hiding this comment.
This was confusing test results by printing out-of-order
mmastrac
commented
Jun 29, 2023
tools/wpt.ts
Outdated
| @@ -611,6 +611,7 @@ function reportVariation(result: TestResult, expectation: boolean | string[]) { | |||
| for (const result of expectedFailedButPassed) { | |||
| console.log(` ${JSON.stringify(result.name)}`); | |||
| } | |||
| console.log("\nstderr:\n" + result.stderr); | |||
There was a problem hiding this comment.
This makes stderr output consistent.
mmastrac
commented
Jun 29, 2023
| @@ -567,8 +567,9 @@ function analyzeTestResult( | |||
|
|
|||
| function reportVariation(result: TestResult, expectation: boolean | string[]) { | |||
| if (result.status !== 0 || result.harnessStatus === null) { | |||
| console.log(`test stderr:`); | |||
| writeAllSync(Deno.stdout, new TextEncoder().encode(result.stderr)); | |||
| if (result.stderr) { | |||
There was a problem hiding this comment.
Print stderr consistently between modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the WPT tests that test w/invalid codes. Also explicitly ignoring some h2 tests to hopefully prevent flakes.
The previous changes to WebSocketStream introduced a bug where the close errors were not made available if the
pullmethod was re-entrant.