Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): add assert function #19635

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix(console): add assert function #19635

merged 1 commit into from
Jun 28, 2023

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Jun 28, 2023 •
edited
Loading

Fixes #19471
Not sure how we can test this: in the issue, a Request is being logged, but that by itself works fine. seems very unique circumstances.

@crowlKats crowlKats merged commit 558eb9f into denoland:main Jun 28, 2023
11 checks passed
@crowlKats crowlKats deleted the assert_console branch June 28, 2023 15:29
@Mqxx
Copy link

Mqxx commented Jun 29, 2023

Fixes #19471 Not sure how we can test this: in the issue, a Request is being logged, but that by itself works fine. seems very unique circumstances.

#19471 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.serve() WebSocket request throws ReferenceError
3 participants
@crowlKats @Mqxx @bartlomieju