Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ext/node): clean up node:path test cases #19610

Merged
merged 3 commits into from
Jul 5, 2023
Merged

test(ext/node): clean up node:path test cases #19610

merged 3 commits into from
Jul 5, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 26, 2023

This PR cleans up node:path test cases.

  • parallel/test-path.js now passes without modification. This PR removes test-path.js entry from ignore list of compat test settings, and copies the original test to cli/tests/node_compat/test/parallel/test-path.js. (by tools/node_compat/setup.ts)
  • Assertions about object references (added in fix(node/path): Remove toFileUrl #19536) are not available in compat test cases. Moved those assertions to our own unit test file (cli/tests/unit_node/path_test.ts).

@kt3k kt3k requested a review from bartlomieju June 26, 2023 04:31
bartlomieju
bartlomieju approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit cd2525d into denoland:main Jul 5, 2023
10 checks passed
@kt3k kt3k deleted the clean-up-node-path-tests branch July 5, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kt3k @bartlomieju @aapoalas