Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eager code is very complicated for very little benefit. By removing it, tail latency (which is VERY BAD currently) is reduced by half. Absolute req/sec is slightly slower tho - I still think it makes sense to remove.
Here I'm running
./target/release/deno tests/http_bench.ts -A
Without eager (this branch)
With eager (master)
Furthermore this suggests that maybe the tail latency problems experienced in
deno_core_http_bench
are due to an over-eager event loop (the while loop indeno_core::Isolate::poll()
)