Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement init scripts in core #1958

Merged
merged 3 commits into from
Mar 19, 2019
Merged

Re-implement init scripts in core #1958

merged 3 commits into from
Mar 19, 2019

Conversation

afinch7
Copy link
Contributor

@afinch7 afinch7 commented Mar 18, 2019 •
edited
Loading

Somewhere along the way script based isolate init got dropped. I've re-implemented it in core, and made some changes like replace struct IsolateInit with a enum StartupData. fixes #1937

ry
ry reviewed Mar 18, 2019
View reviewed changes
core/http_bench.rs Outdated Show resolved Hide resolved
ry
ry reviewed Mar 18, 2019
View reviewed changes
core/isolate.rs Outdated Show resolved Hide resolved
ry
ry reviewed Mar 18, 2019
View reviewed changes
src/cli.rs Show resolved Hide resolved
ry
ry approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for putting up with the test disabling : )

@ry ry merged commit cdfd32d into denoland:master Mar 19, 2019
ry pushed a commit to ry/deno that referenced this pull request Mar 19, 2019
@afinch7 @ry
Re-implement init scripts in core (denoland#1958)
041269d 
Re-enables arm64 CI test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

re-enable arm64 test
2 participants
@afinch7 @ry