Revert "refactor(core): cleanup feature flags for js source inclusion… #19490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…denoland#19463)" This reverts commit ceb03cf.
mmastrac
approved these changes
Jun 13, 2023
bartlomieju
added a commit
that referenced
this pull request
Jun 15, 2023
#19490) … (#19463)" This reverts commit ceb03cf. This is being reverted because it causes 3.5Mb increase in the binary size, due to runtime JS code being included in the binary, even though it's already snapshotted. CC @nayeemrmn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#19463)"
This reverts commit ceb03cf.
This is being reverted because it causes 3.5Mb increase in the binary size,
due to runtime JS code being included in the binary, even though it's
already snapshotted.
CC @nayeemrmn