fix(node/buffer): make slice be the same as subarray #19481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
changed the title
aapoalas
reviewed
Jun 13, 2023
| const newBuf = this.subarray(start, end); | ||
| Object.setPrototypeOf(newBuf, Buffer.prototype); | ||
| return newBuf; | ||
| return this.subarray(start, end); |
There was a problem hiding this comment.
Question: Does subarray return a Buffer or a Uint8Array?
bartlomieju
requested changes
Jun 13, 2023
| const newBuf = this.subarray(start, end); | ||
| Object.setPrototypeOf(newBuf, Buffer.prototype); | ||
| return newBuf; | ||
| return this.subarray(start, end); |
There was a problem hiding this comment.
I think this is wrong. Slice returns a clone while subarray returns a view on the same array.
There was a problem hiding this comment.
i thought so as well, however, per node docs:
Returns a new Buffer that references the same memory as the original, but offset and cropped by the start and end indices.
This method is not compatible with the Uint8Array.prototype.slice(), which is a superclass of Buffer. To copy the slice, use Uint8Array.prototype.slice().
and node does the same as i am doing here
bartlomieju
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.