Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/console): fix inspecting large ArrayBuffers #19373

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

0f-0b
Copy link
Contributor

@0f-0b 0f-0b commented Jun 5, 2023

An ArrayBuffer with a byteLength greater than 2^32 was incorrectly reported as detached.

$ deno eval 'console.log(new ArrayBuffer(2 ** 32 + 1))'
ArrayBuffer { (detached), byteLength: 4294967297 }
$ target/debug/deno eval 'console.log(new ArrayBuffer(2 ** 32 + 1))'
ArrayBuffer {
  [Uint8Contents]: <00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ... 4294967197 more bytes>,
  byteLength: 4294967297
}

Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 2052ba3 into denoland:main Jun 6, 2023
10 checks passed
@0f-0b 0f-0b deleted the fix-inspect-large-arraybuffer branch June 6, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants