Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a missing import in manual.md example for testing #1935

Merged
merged 3 commits into from
Mar 16, 2019
Merged

Fix a missing import in manual.md example for testing #1935

merged 3 commits into from
Mar 16, 2019

Conversation

joemclo
Copy link
Contributor

@joemclo joemclo commented Mar 15, 2019 •
edited
Loading

There may be a more appropriate fix for the error in the manual so feel free to close and I will create an issue.

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ry
Copy link
Member

ry commented Mar 15, 2019

Thanks! Can you run tools/format.py please ?

ry
ry approved these changes Mar 16, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 785b48a into denoland:master Mar 16, 2019
@joemclo joemclo deleted the fixManualTestExample branch March 17, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joemclo @CLAassistant @ry @joemcloE