Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more options to Deno.inspect #19337

Merged
merged 4 commits into from
Jun 5, 2023
Merged

feat: add more options to Deno.inspect #19337

merged 4 commits into from
Jun 5, 2023

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Jun 1, 2023 •
edited
Loading

@crowlKats crowlKats requested a review from kt3k June 1, 2023 11:57
@kt3k
Copy link
Member

kt3k commented Jun 1, 2023

Note: std's snapshot testing feature uses Deno.inspect as the serializer of target object. ref: https://github.com/denoland/deno_std/blob/fdabe55e2dd29df626ecb5b4496b091478298eaf/testing/snapshot.ts#L199-L208

The way of Deno.inspect to serialize long string values are changed in #18691 and now the string snapshots have a lot of noise and very uncomfortable to compare.

This PR tries to restore the previous behavior optionally and prepares for addressing denoland/std#3404

kt3k
kt3k approved these changes Jun 3, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 08bd239 into denoland:main Jun 5, 2023
10 checks passed
@crowlKats crowlKats deleted the more_inspect_options branch June 5, 2023 10:26
bartlomieju pushed a commit that referenced this pull request Jun 8, 2023
@crowlKats @kt3k @bartlomieju
feat: add more options to Deno.inspect (#19337)
26506ff 
For denoland/std#3404

---------

Co-authored-by: Yoshiya Hinosawa <[email protected]>
This was referenced Jul 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@hexiaokang hexiaokang hexiaokang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crowlKats @kt3k @hexiaokang