feat: Add an OpenBSD implementation for rss() #19221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
requested changes
Jun 1, 2023
There was a problem hiding this comment.
I have not much of a clue of these libc level things but at least for the most part looks like code, perhaps even reasonable code.
Some nitpicks / questions / suggestions aside, safety comments must be added to every unsafe and I think comments in general would be lovely :)
aapoalas
approved these changes
Jun 2, 2023
bartlomieju
pushed a commit
that referenced
this pull request
Jun 8, 2023
In case you would consider including specific implementations and not only build fixes, here's the implementation of the ```rss()``` function for OpenBSD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you would consider including specific implementations and not only build fixes, here's the implementation of the
rss()function for OpenBSD.