Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: further work on node http client #19211

Merged
merged 15 commits into from
May 23, 2023
Merged

refactor: further work on node http client #19211

merged 15 commits into from
May 23, 2023

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented May 21, 2023 •
edited
Loading

Fixes #19209
Fixes #19215

@crowlKats crowlKats changed the title further work on node http client refactor: further work on node http client May 21, 2023
@levex
Copy link
Contributor

levex commented May 22, 2023

setTimeout piece looks good to me!

bartlomieju
bartlomieju approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tried it and it appears the issues are fixed. Nice work Leo

@crowlKats crowlKats merged commit 5878258 into denoland:main May 23, 2023
10 checks passed
@crowlKats crowlKats deleted the http_client_further_work branch May 23, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@crowlKats @levex @bartlomieju